Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch main Dockerfile to use binary Debian packages #118

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Conversation

wohali
Copy link
Member

@wohali wohali commented Dec 3, 2018

Overview

Simplify our build environment by simply relying on the pre-built Debian .deb packages for CouchDB, rather than installing all of the build dependencies, building CouchDB from scratch, then removing them all.

Don't Repeat Yourself.

I've also added a VOLUME definition for /opt/couchdb/etc/local.d since we recommend externally mounting this anyway. @kocolosk does this cause any concern for the helm/k8s stuff at all?

Testing recommendations

Travis CI should build the image from scratch and test it on our behalf - if it's green, we're good.

GitHub issue number

Closes #117

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@wohali wohali requested a review from kocolosk December 3, 2018 23:23
@wohali
Copy link
Member Author

wohali commented Dec 3, 2018

Ironically, changes in our Python requirements (python3) means building the dev* images is broken. I'll open a new PR for that, then rebase this once it merges.

@wohali
Copy link
Member Author

wohali commented Dec 4, 2018

Koco has already +1'ed this idea in #117 , so I'm merging.

@wohali wohali closed this Dec 4, 2018
@wohali wohali reopened this Dec 4, 2018
@wohali
Copy link
Member Author

wohali commented Dec 4, 2018

It would help if I could press the right button.

@wohali wohali merged commit 6359c41 into master Dec 4, 2018
@wohali wohali deleted the 117-apt-get branch December 4, 2018 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant