Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move string kernels and expressions to spark-expr crate #1164

Merged
merged 3 commits into from
Dec 12, 2024
Merged

chore: Move string kernels and expressions to spark-expr crate #1164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
538d484
Move string kernels and expressions to spark-expr crate
andygrove Dec 12, 2024
bda2f4e
remove unused hash kernel
andygrove Dec 12, 2024
c988c66
remove unused dependencies
andygrove Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions native/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions native/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ arrow-buffer = { workspace = true }
arrow-data = { workspace = true }
arrow-schema = { workspace = true }
parquet = { workspace = true, default-features = false, features = ["experimental"] }
half = { version = "2.4.1", default-features = false }
futures = { workspace = true }
mimalloc = { version = "*", default-features = false, optional = true }
tokio = { version = "1", features = ["rt-multi-thread"] }
Expand All @@ -62,7 +61,6 @@ rand = { workspace = true}
num = { workspace = true }
bytes = "1.5.0"
tempfile = "3.8.0"
ahash = { version = "0.8", default-features = false }
itertools = "0.11.0"
paste = "1.0.14"
datafusion-common = { workspace = true }
Expand Down Expand Up @@ -102,10 +100,6 @@ harness = false
name = "bit_util"
harness = false

[[bench]]
name = "hash"
harness = false

[[bench]]
name = "row_columnar"
harness = false
Expand Down
137 changes: 0 additions & 137 deletions native/core/benches/hash.rs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion native/core/src/execution/datafusion/expressions/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ use crate::errors::CometError;
pub mod bloom_filter_agg;
pub mod bloom_filter_might_contain;
pub mod negative;
pub mod strings;
pub mod subquery;
pub mod unbound;

Expand Down
15 changes: 6 additions & 9 deletions native/core/src/execution/datafusion/planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,8 @@ use crate::{
datafusion::{
expressions::{
bloom_filter_agg::BloomFilterAgg,
bloom_filter_might_contain::BloomFilterMightContain,
checkoverflow::CheckOverflow,
negative,
strings::{Contains, EndsWith, Like, StartsWith, StringSpaceExpr, SubstringExpr},
subquery::Subquery,
unbound::UnboundColumn,
bloom_filter_might_contain::BloomFilterMightContain, checkoverflow::CheckOverflow,
negative, subquery::Subquery, unbound::UnboundColumn,
},
operators::expand::CometExpandExec,
shuffle_writer::ShuffleWriterExec,
Expand Down Expand Up @@ -90,9 +86,10 @@ use datafusion_comet_proto::{
spark_partitioning::{partitioning::PartitioningStruct, Partitioning as SparkPartitioning},
};
use datafusion_comet_spark_expr::{
ArrayInsert, Avg, AvgDecimal, BitwiseNotExpr, Cast, Correlation, Covariance, CreateNamedStruct,
DateTruncExpr, GetArrayStructFields, GetStructField, HourExpr, IfExpr, ListExtract, MinuteExpr,
NormalizeNaNAndZero, RLike, SecondExpr, SparkCastOptions, Stddev, SumDecimal,
ArrayInsert, Avg, AvgDecimal, BitwiseNotExpr, Cast, Contains, Correlation, Covariance,
CreateNamedStruct, DateTruncExpr, EndsWith, GetArrayStructFields, GetStructField, HourExpr,
IfExpr, Like, ListExtract, MinuteExpr, NormalizeNaNAndZero, RLike, SecondExpr,
SparkCastOptions, StartsWith, Stddev, StringSpaceExpr, SubstringExpr, SumDecimal,
TimestampTruncExpr, ToJson, Variance,
};
use datafusion_common::scalar::ScalarStructBuilder;
Expand Down
Loading
Loading