Error on dangling NO in CREATE SEQUENCE options (#1104)

apache · Jan 24, 2024 · 498708c · 498708c
1 parent 3a6d3ec
commit 498708c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/parser/mod.rs b/src/parser/mod.rs
@@ -8700,13 +8700,12 @@ impl<'a> Parser<'a> {
             )));
         }
         // [ [ NO ] CYCLE ]
-        if self.parse_keywords(&[Keyword::NO]) {
-            if self.parse_keywords(&[Keyword::CYCLE]) {
-                sequence_options.push(SequenceOptions::Cycle(true));
-            }
+        if self.parse_keywords(&[Keyword::NO, Keyword::CYCLE]) {
+            sequence_options.push(SequenceOptions::Cycle(true));
         } else if self.parse_keywords(&[Keyword::CYCLE]) {
             sequence_options.push(SequenceOptions::Cycle(false));
         }
+
         Ok(sequence_options)
     }
 

diff --git a/tests/sqlparser_postgres.rs b/tests/sqlparser_postgres.rs
@@ -276,6 +276,11 @@ fn parse_create_sequence() {
         sql6,
         "CREATE TEMPORARY SEQUENCE IF NOT EXISTS name3 INCREMENT 1 NO MINVALUE MAXVALUE 20 OWNED BY NONE",
     );
+
+    assert!(matches!(
+        pg().parse_sql_statements("CREATE SEQUENCE foo INCREMENT 1 NO MINVALUE NO"),
+        Err(ParserError::ParserError(_))
+    ));
 }
 
 #[test]