Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mysql): Increased compatibility for MySQL #1059

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

zzzdong
Copy link
Contributor

@zzzdong zzzdong commented Nov 30, 2023

  1. Add support LOCK/UNLOCK TABLES for MySQL.
  2. Fix parse CREATE TABLE sql from SHOW CREATE TABLE.

May fix parts of #302 .

1. Add support `LOCK/UNLOCK` TABLES.
2. FIX parse `CREATE TABLE` sql from `SHOW CREATE TABLE`.
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thank you @zzzdong

I took the liberty of merging up from main to resolve a conflict on this branch

@coveralls
Copy link

coveralls commented Dec 19, 2023

Pull Request Test Coverage Report for Build 7267163251

  • 80 of 85 (94.12%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 87.733%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/mysql.rs 27 28 96.43%
src/parser/mod.rs 10 11 90.91%
src/ast/mod.rs 23 26 88.46%
Totals Coverage Status
Change from base Build 7267000812: 0.03%
Covered Lines: 18187
Relevant Lines: 20730

💛 - Coveralls

@alamb alamb merged commit d0fce12 into apache:main Dec 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants