Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Snowflake dynamic pivot #1280

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

jmhain
Copy link
Contributor

@jmhain jmhain commented May 21, 2024

Snowflake just gained a nifty new feature called Dynamic Pivot. This adds parser support for it (+ another PIVOT option that I noticed we were missing support for in the process).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9167250918

Details

  • 37 of 39 (94.87%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.479%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/query.rs 9 10 90.0%
src/parser/mod.rs 19 20 95.0%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_common.rs 1 89.47%
src/ast/query.rs 3 84.38%
Totals Coverage Status
Change from base Build 9166712366: 0.02%
Covered Lines: 24961
Relevant Lines: 27896

💛 - Coveralls

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jmhain and @iffyio

@alamb alamb merged commit c2d84f5 into apache:main May 30, 2024
10 checks passed
@jmhain jmhain deleted the dynamic-pivot branch May 30, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants