Implements ALTER POLICY syntax for PostgreSQL #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```sql
ALTER POLICY name ON table_name RENAME TO new_name
ALTER POLICY name ON table_name
[ TO { role_name | PUBLIC | CURRENT_ROLE | CURRENT_USER | SESSION_USER } [, ...] ]
[ USING ( using_expression ) ]
[ WITH CHECK ( check_expression ) ]
```
For the documentation, please refer:
https://www.postgresql.org/docs/current/sql-alterpolicy.html
git-hulk
force-pushed
the
feature/alter-policy-for-pg
branch
from
753df07 to
5232492
Compare
Pull Request Test Coverage Report for Build 11091759958Details
💛 - Coveralls |
|
cc @iffyio |
iffyio
reviewed
Sep 29, 2024
src/parser/alter.rs
Outdated
Comment on lines
58
to
64
| let to = if self.parse_keyword(Keyword::TO) { | ||
| Some(self.parse_comma_separated(|p| p.parse_owner())?) | ||
| } else { | ||
| None | ||
| }; | ||
|
|
||
| if self.parse_keyword(Keyword::RENAME) { |
There was a problem hiding this comment.
from the doc it looks like the RENAME vs others are are mutually exclusive, so that if we parse a TO it probably won't be correct to potentially also parse a rename afterwards as the current code suggests?
e.g ALTER POLICY a on t TO owner RENAME TO new_name seems like its accepted by the parser?
There was a problem hiding this comment.
@iffyio Yes, you're right. I falsely parsed TO before REANME, will fix it soon. Thank you for your correction.
iffyio
approved these changes
Sep 29, 2024
Co-authored-by: Andrew Lamb <[email protected]>
…parser-rs into feature/alter-policy-for-pg
|
I merged up from main to resolve a conflict |
alamb
reviewed
Sep 29, 2024
|
@alamb Thank you! |
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the documentation, please refer:
https://www.postgresql.org/docs/current/sql-alterpolicy.html