Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to parse extension to parse_comment inside postgres dialect #1451

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

MaxwellKnight
Copy link
Contributor

Hi guys,
First of all i'd say that i'm new to contributing to open source so if I've made a mistake i'm deeply sorry.
Also I made sure to write the relevant tests and I ran cargo test, cargo fmt and cargo clippy and it said in the README.
I added the ability to parse COMMENT ON EXTENSION statements to postgres dialect,
I've been using this crate for a while now and I saw that I get a parser error when I have these kind of statements.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

@alamb
Copy link
Contributor

alamb commented Oct 4, 2024

First of all i'd say that i'm new to contributing to open source so if I've made a mistake i'm deeply sorry.

No need to apologize! Thank you for the contribution -- we appreciate everyone's efforts (it is how we keep these things going)

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaxwellKnight and @iffyio

@alamb alamb merged commit 8ccb87a into apache:main Oct 4, 2024
10 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11131556477

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 16 (87.5%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 89.302%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_postgres.rs 10 12 83.33%
Files with Coverage Reduction New Missed Lines %
src/dialect/postgresql.rs 1 69.47%
Totals Coverage Status
Change from base Build 11111316639: -0.001%
Covered Lines: 29951
Relevant Lines: 33539

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants