Add support for TOP before ALL/DISTINCT #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavcloud
force-pushed
the
redshift_select_top
branch
from
35400c3 to
1752a4a
Compare
iffyio
reviewed
Nov 3, 2024
yoavcloud
force-pushed
the
redshift_select_top
branch
from
72544c3 to
eb698ee
Compare
iffyio
changed the title
iffyio
approved these changes
Nov 6, 2024
…SELECT statement to appear before the ALL/DISTINCT option
yoavcloud
force-pushed
the
redshift_select_top
branch
from
3d25465 to
9eec5f3
Compare
alamb
changed the title
Pull Request Test Coverage Report for Build 11707166854Details
💛 - Coveralls |
|
Thanks @yoavcloud and @iffyio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for dialects (Redshift) that expect the TOP keyword in a SELECT statement to appear before the ALL/DISTINCT option. For example: SELECT TOP 2 DISTINCT FROM tbl;
https://docs.aws.amazon.com/redshift/latest/dg/r_SELECT_list.html