Improve parsing speed by avoiding some clones in parse_identifier #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Dec 28, 2024
| @@ -970,15 +970,15 @@ impl<'a> Parser<'a> { | |||
| t @ (Token::Word(_) | Token::SingleQuotedString(_)) => { | |||
| if self.peek_token().token == Token::Period { | |||
| let mut id_parts: Vec<Ident> = vec![match t { | |||
| Token::Word(w) => w.to_ident(next_token.span), | |||
| Token::Word(w) => w.into_ident(next_token.span), | |||
There was a problem hiding this comment.
w.to_ident cloned (copied) the string. info_ident simply reuses the string
| @@ -1108,7 +1108,7 @@ impl<'a> Parser<'a> { | |||
| if dialect_of!(self is PostgreSqlDialect | GenericDialect) => | |||
| { | |||
| Ok(Some(Expr::Function(Function { | |||
| name: ObjectName(vec![w.to_ident(w_span)]), | |||
| name: ObjectName(vec![w.clone().into_ident(w_span)]), | |||
There was a problem hiding this comment.
in this case I couldn't figure out (yet) how to avoid this clone given that &w is passed in
This PR doesn't increase the number of clones done, but it makes it more explicit when they are happening
| @@ -13475,13 +13477,23 @@ impl<'a> Parser<'a> { | |||
| } | |||
|
|
|||
| impl Word { | |||
| #[deprecated(since = "0.55.0", note = "please use `into_ident` instead")] | |||
| pub fn to_ident(&self, span: Span) -> Ident { | |||
| Ident { | |||
| value: self.value.clone(), | |||
There was a problem hiding this comment.
note to_indent clones self.value
alamb
commented
Dec 28, 2024
alamb
commented
Dec 28, 2024
| @@ -13475,13 +13477,23 @@ impl<'a> Parser<'a> { | |||
| } | |||
|
|
|||
| impl Word { | |||
| #[deprecated(since = "0.54.0", note = "please use `into_ident` instead")] | |||
There was a problem hiding this comment.
I am trying to help any downstream crates that may also use this function with a deprecation notice rather than simply removing the function immediately
alamb
changed the title
iffyio
approved these changes
Dec 29, 2024
| @@ -13475,13 +13477,23 @@ impl<'a> Parser<'a> { | |||
| } | |||
|
|
|||
| impl Word { | |||
| #[deprecated(since = "0.54.0", note = "please use `into_ident` instead")] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokens as much #1558I made a flamegraph of the
sqlparser_benchand found a few unnecessary clonesThis PR avoids a clone (string copy) in parse_identifier.
I don't think this will make things much faster (yet), but it makes clear where the cloning is happening.
I hope to optimize the speed of parsing identifiers more as a follow on PR.