-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manually implemented AST visitor #758
Conversation
Pull Request Test Coverage Report for Build 3685169537
💛 - Coveralls |
So what I would really like to do is to figure out some way to automatically generate this code (like using |
// limitations under the License. | ||
|
||
use crate::ast::{Expr, ObjectName, Statement}; | ||
use core::ops::ControlFlow; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL: ControlFlow
I'll have a play with what a proc-macro / codegen setup looks like |
I think the approach in #765 is much more maintainable that this, which I think would be non-trivial to maintain and would act as a potential barrier to contribution |
Related to #78, #114, #601
This implements a basic AST visitor. I'm not convinced this is the best way to implement this, as it is relatively fragile, but I wanted to get something up to acts as a comparison point