-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DuckDB's CREATE MACRO statements #897
Conversation
- support scalar and table macros
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MartinNowak -- this is looking pretty close. I left some comments let me know what you think
635fd33
to
618ad71
Compare
618ad71
to
088b2fe
Compare
Thanks for the detailed review @alamb, resolved all points except this discussion. |
Thanks @MartinNowak -- I am a behind on reviews. I plan to review this tomorrow. Sorry for the delay |
Pull Request Test Coverage Report for Build 5309894222
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me -- thank you @MartinNowak
parsing to avoid plenty of runtime dialect switches