use into_values() instead of into_iter() where possible

apache · Jun 16, 2024 · 6b1d1e3 · 6b1d1e3
1 parent 63c3370
commit 6b1d1e3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/datafusion/optimizer/src/common_subexpr_eliminate.rs b/datafusion/optimizer/src/common_subexpr_eliminate.rs
@@ -324,8 +324,8 @@ impl CommonSubexprEliminate {
                 .map(LogicalPlan::Aggregate)
         } else {
             let mut agg_exprs = common_exprs
-                .into_iter()
-                .map(|(_, (expr, expr_alias))| expr.alias(expr_alias))
+                .into_values()
+                .map(|(expr, expr_alias)| expr.alias(expr_alias))
                 .collect::<Vec<_>>();
 
             let mut proj_exprs = vec![];
@@ -497,8 +497,8 @@ fn build_common_expr_project_plan(
 ) -> Result<LogicalPlan> {
     let mut fields_set = BTreeSet::new();
     let mut project_exprs = common_exprs
-        .into_iter()
-        .map(|(_, (expr, expr_alias))| {
+        .into_values()
+        .map(|(expr, expr_alias)| {
             fields_set.insert(expr_alias.clone());
             Ok(expr.alias(expr_alias))
         })