refactor: complete 2 TODOs in self review

apache · Feb 21, 2024 · bed7322 · bed7322
1 parent f49ac14
commit bed7322
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/datafusion/functions/src/math/acos.rs b/datafusion/functions/src/math/acos.rs
@@ -82,7 +82,7 @@ impl ScalarUDFImpl for AcosFunc {
             DataType::Float32 => {
                 Arc::new(make_function_scalar_inputs_return_type!(
                             &args[0],
-                            "x",
+                            self.name(),
                             Float32Array,
                             Float32Array,
                             { f32::acos }

diff --git a/datafusion/proto/Cargo.toml b/datafusion/proto/Cargo.toml
@@ -47,7 +47,6 @@ chrono = { workspace = true }
 datafusion = { path = "../core", version = "36.0.0" }
 datafusion-common = { workspace = true }
 datafusion-expr = { workspace = true }
-datafusion-functions = { workspace = true }
 object_store = { workspace = true }
 pbjson = { version = "0.6.0", optional = true }
 prost = "0.12.0"