Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the sqllogictest runner on Windows #4494

Closed
Tracked by #4460
mvanschellebeeck opened this issue Dec 4, 2022 · 0 comments · Fixed by risinglightdb/sqllogictest-rs#139 or #5870
Closed
Tracked by #4460

Fix the sqllogictest runner on Windows #4494

mvanschellebeeck opened this issue Dec 4, 2022 · 0 comments · Fixed by risinglightdb/sqllogictest-rs#139 or #5870
Labels
bug Something isn't working sqllogictest SQL Logic Tests (.slt)

Comments

@mvanschellebeeck
Copy link
Contributor

Describe the bug
The runner currently fails on Windows - see line 2098 to 2961 of this CI failure. It looks like its failing to split on a new line at the end of SELECT avg(c12) FROM aggregate_test_100 and is reading the entire aggregate.slt file as a string.
@mvanschellebeeck mvanschellebeeck added the bug Something isn't working label Dec 4, 2022
@mvanschellebeeck mvanschellebeeck changed the title Fix the sqllogictest runenr on Windows Fix the sqllogictest runner on Windows Dec 4, 2022
@mvanschellebeeck mvanschellebeeck mentioned this issue Dec 4, 2022
Closed
28 tasks
@xudong963 xudong963 added the sqllogictest SQL Logic Tests (.slt) label Dec 4, 2022
@mrob95 mrob95 mentioned this issue Jan 3, 2023
Merged
xxchan pushed a commit to risinglightdb/sqllogictest-rs that referenced this issue Jan 3, 2023
@mrob95
Use lines() instead of split('\n') in parse_inner (#139)
cb3c99d 
fix apache/datafusion#4494
@melgenek melgenek mentioned this issue Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
2 participants
@mvanschellebeeck @xudong963