Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change FixedSizeList Scalar to use array #8218

Closed
wjones127 opened this issue Nov 15, 2023 · 0 comments · Fixed by #8221
Closed

Change FixedSizeList Scalar to use array #8218

wjones127 opened this issue Nov 15, 2023 · 0 comments · Fixed by #8221
Assignees
@wjones127
Labels
api change Changes the API exposed to users of the crate enhancement New feature or request

Comments

@wjones127
Copy link
Member

Is your feature request related to a problem or challenge?

We changed ScalarValue::List to wrap an array ref in #7352. But FixedSizeList is still a Vec<ScalarValue>. There shouldn't be varying data types there, so storing as a Vec<ScalarValue> seems inefficient and potentially error-prone.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response
@wjones127 wjones127 added the enhancement New feature or request label Nov 15, 2023
@wjones127 wjones127 self-assigned this Nov 15, 2023
@wjones127 wjones127 added the api change Changes the API exposed to users of the crate label Nov 15, 2023
@wjones127 wjones127 mentioned this issue Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wjones127 wjones127

Labels
api change Changes the API exposed to users of the crate enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make FixedSizeList scalar also an ArrayRef apache/datafusion
1 participant
@wjones127