feat: make FixedSizeList scalar also an ArrayRef #8221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
added
enhancement
wjones127
changed the title
|
cc @jayzhan211 |
This was referenced Nov 15, 2023
jayzhan211
reviewed
Nov 15, 2023
| @@ -1032,8 +1020,11 @@ impl ScalarValue { | |||
| ScalarValue::Binary(v) => v.is_none(), | |||
| ScalarValue::FixedSizeBinary(_, v) => v.is_none(), | |||
| ScalarValue::LargeBinary(v) => v.is_none(), | |||
| ScalarValue::Fixedsizelist(v, ..) => v.is_none(), | |||
| ScalarValue::List(arr) => arr.len() == arr.null_count(), | |||
| // arr.len() should be 1 for a list scalar, but we don't seem to | |||
There was a problem hiding this comment.
why arr.len() should be 1? I thought it can be any kind of ListArray
There was a problem hiding this comment.
If arr.len() > 1, it isn't a scalar. arr is a ListArray or FixedSizeListArray, so arr.len() == 1 means there is one list.
I think we dont need, we just assume we have FixedSizeList as ArrayRef |
jayzhan211
approved these changes
Nov 16, 2023
Weijun-H
approved these changes
Nov 16, 2023
comphead
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Changes
ScalarValue::FixedSizeList()to wrap anArrayRef. This is an API breaking change, so while I did this I also fixed the capitalization of the nameFixedsizelisttoFixedSizeList, so it's consistent with the data and array type in arrow-rs.Closes #8218.
Rationale for this change
We can re-use a lot of functions with
ScalarValue::List, and this representation leaves less room for invalid state (for example, previously one could create a scalar that contained scalar values of varying data type).What changes are included in this PR?
ScalarValue::FixedsizelisttoScalarValue::FixedSizeList.ScalarValue::FixedSizeListto wrap an array ref.Are these changes tested?
There's not much testing for this type. I can work on adding more tests in #8220.
Are there any user-facing changes?
Yes, this is a breaking API change.