Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 10333 / changes to aliasing in CommonSubExprEliminate #10436

Merged
merged 2 commits into from
May 10, 2024

Conversation

MohamedAbdeen21
Copy link
Contributor

@MohamedAbdeen21 MohamedAbdeen21 commented May 9, 2024

Which issue does this PR close?

Revert #10333

related to #10280

Rationale for this change

This issue is to be revisited after #10413.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt) labels May 9, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MohamedAbdeen21

For anyone following along, the rationale to revert is here: #10333 (comment)

cc @peter-toth

@alamb alamb changed the title Revert 10333 Revert 10333 / changes to aliasing in CommonSubExprEliminate May 10, 2024
@alamb alamb merged commit 975ea5e into apache:main May 10, 2024
24 checks passed
@alamb
Copy link
Contributor

alamb commented May 10, 2024

Thanks again!

findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
…10436)

* Revert "make common expression alias human-readable (apache#10333)"

This reverts commit 2a15614.

* keep some ok parts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants