Minor: SMJ fuzz tests fix for rowcounts #10891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edmondop cc |
|
Thanks, why does changing the threshold fix the problem? |
it doesn't fix the threshold, the method name renamed, I think it takes less than 100 right? The actual fix is how to calculate rowcounts. |
edmondop
approved these changes
Jun 12, 2024
alamb
approved these changes
Jun 12, 2024
| ); | ||
| // row level compare if any of joins returns the result | ||
| // the reason is different formatting when there is no rows | ||
| if smj_rows > 0 || hj_rows > 0 { |
There was a problem hiding this comment.
I double checked that the assert on row count is done higher up 👍
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Fix: Sort Merge Join crashes on TPCH Q21 * Fix LeftAnti SMJ join when the join filter is set * rm dbg * Minor: Fix fuzz testing row counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10886.
Rationale for this change
The fuzz tests for filtered SMJ introduced in #10728 has a flaw when calculating the rowcounts, it fact it caculcated batches which are not always the same and led to false negatives.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?