Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated rewrite_expr.rs example #11085

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 23, 2024

Which issue does this PR close?

Part of #10855

Rationale for this change

rewrite_expr.rs has three distinct examples within it it. These now all have their own examples (done in the following PRs)

  1. Using DataFusion LogicalPlanning without execution: Add standalone example of using the SQL frontend #11088
  2. Implementing an AnalyzerRule: Add standalone AnalyzerRule example that implements row level access control #11089
  3. Implementing an OptimizerRule: Add standalone example for OptimizerRule #11087

What changes are included in this PR?

  1. Remove (now) redundant example

Are these changes tested?

Existing CI

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Jun 23, 2024
@alamb alamb changed the title Alamb/remove rewrite expr Remove outdated rewrite_expr.rs example Jun 23, 2024
@alamb alamb marked this pull request as ready for review July 2, 2024 15:52
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit 351e5f9 into apache:main Jul 5, 2024
24 checks passed
comphead pushed a commit to comphead/arrow-datafusion that referenced this pull request Jul 8, 2024
* Remove outdated rewrite_expr.rs example

* Update docs
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
* Remove outdated rewrite_expr.rs example

* Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants