Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ByteViewMap block size to 2MB #11674

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Increase ByteViewMap block size to 2MB #11674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d965e35
better default block size
XiangpengHao Jul 26, 2024
58ce106
fix related test
XiangpengHao Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datafusion/physical-expr-common/src/binary_view_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ where
output_type,
map: hashbrown::raw::RawTable::with_capacity(INITIAL_MAP_CAPACITY),
map_size: 0,
builder: GenericByteViewBuilder::new(),
builder: GenericByteViewBuilder::new().with_block_size(2 * 1024 * 1024),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After apache/arrow-rs#6136 is merged, will this be needed anymore?

random_state: RandomState::new(),
hashes_buffer: vec![],
null: None,
Expand Down Expand Up @@ -545,7 +545,7 @@ mod tests {
// Much larger strings in strings2
let strings2 = StringViewArray::from(vec![
"FOO".repeat(1000),
"BAR larger than 12 bytes.".repeat(1000),
"BAR larger than 12 bytes.".repeat(100_000),
"more unique.".repeat(1000),
"more unique2.".repeat(1000),
"FOO".repeat(3000),
Expand Down
Loading