-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bloom filter Join Step I: create benchmark #11933
Conversation
02b1a4a
to
d67a600
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Lordworms -- I realize i am very behind on reviews in DataFusion
My first question on these benchmarks is are they measuring the right thing (namely are they dominated by the join time). Have you had a chance to run any profiling (flamegraphs, etc) to confirm these benchmarks are actually join dominated?
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look |
I think it worth a try to implement join predicate pushdown |
d67a600
to
bda2096
Compare
I suggest we revive this PR as it seems to have gotten lost / not reviewed 😢 |
I am still working on the implementation of actual join_pushdown, I'll push a complete PR once it is done |
I am still working on the implementation of actual "hash_join build side statistic pushdown", I'll push a complete PR once it is done |
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Which issue does this PR close?
part of #7955
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?