Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary shifts in gcd() #12480

Merged

Conversation

findepi
Copy link
Member

@findepi findepi commented Sep 15, 2024

The a and b are shifted as a next instruction.

The `a` and `b` are shifted as a next instruction.
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given all the tests pass this looks good to me. Thanks for the cleanup @findepi

@Dandandan Dandandan merged commit a08f923 into apache:main Sep 16, 2024
24 checks passed
@Dandandan
Copy link
Contributor

Thank you @findepi

@findepi findepi deleted the findepi/remove-unnecessary-shifts-in-gcd-7a3c55 branch September 17, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants