[fix]: Coerce integer values for substr
#13154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
reviewed
Oct 29, 2024
Comment on lines
196
to
199
| query T | ||
| select substr(123456, 3); | ||
| ---- | ||
| 3456 |
There was a problem hiding this comment.
string/string_literal.slt is used to collect the string-related test. It's better to move it there.
Dandandan
reviewed
Oct 29, 2024
| @@ -94,6 +94,7 @@ impl ScalarUDFImpl for SubstrFunc { | |||
| let first_data_type = match &arg_types[0] { | |||
| DataType::Null => Ok(DataType::Utf8), | |||
| DataType::LargeUtf8 | DataType::Utf8View | DataType::Utf8 => Ok(arg_types[0].clone()), | |||
| DataType::Int64 | DataType::Int32 => Ok(DataType::Utf8), // Allows for first arg to be int | |||
There was a problem hiding this comment.
DataType::UInt64, DataType::UInt32 as well?
What about any type that can be coerced to Utf8?
There was a problem hiding this comment.
I also forget why this function needs custom coercion logic. I feel like we should be able to do this with a Signature as the same logic could/should apply to any function that takes a string as argument 🤔
|
In Postgres and DuckDB, they don't accept integer as the first input, I suggest we follow them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13150.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?