Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor add ticket references to deprecated code #14174

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 17, 2025

Which issue does this PR close?

Follow on to

Rationale for this change

I filed a ticket to track the removal of some deprecated features and wanted to leave the information in the code as comments for my future self

What changes are included in this PR?

Add some references to the relevant ticket in the relevant code

Are these changes tested?

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review January 17, 2025 18:31
@github-actions github-actions bot added the proto Related to proto crate label Jan 17, 2025
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alamb

@jonahgao jonahgao merged commit f667a01 into apache:main Jan 20, 2025
25 checks passed
@alamb alamb deleted the alamb/add_ref branch January 20, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proto Related to proto crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants