refactor: switch BooleanBufferBuilder to NullBufferBuilder in binary_map
#14341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudong963
approved these changes
Jan 28, 2025
| null_builder.append_n_non_nulls(null_index); | ||
| null_builder.append_null(); | ||
| null_builder.append_n_non_nulls(num_values - null_index - 1); | ||
| null_builder.finish().unwrap() |
There was a problem hiding this comment.
it seems the unwrap is safe because upstream returns Some(xxx).
There was a problem hiding this comment.
if it is @Chen-Yuan-Lai please add the comment that we know .unwrap is safe here
There was a problem hiding this comment.
Thanks @xudong963 and @comphead , I have added the comment
rluvaton
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14115 .
Rationale for this change
As mentioned in #14115 , several examples in DataFusion codebase still using BooleanBufferBuilder rather than NullBufferBuilder, they should be replaced with NullBufferBuilder for optimization.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?