Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some tests from core to expr #2700

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jun 5, 2022

Which issue does this PR close?

Part of #2683

Rationale for this change

Some tests got left behind during the recent refactoring

What changes are included in this PR?

Move some tests to live with the code they are testing

Are there any user-facing changes?

No

@andygrove andygrove self-assigned this Jun 5, 2022
@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions labels Jun 5, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2700 (0d748b6) into master (9306534) will increase coverage by 0.00%.
The diff coverage is 94.82%.

@@           Coverage Diff           @@
##           master    #2700   +/-   ##
=======================================
  Coverage   84.66%   84.66%           
=======================================
  Files         270      270           
  Lines       46919    46919           
=======================================
+ Hits        39724    39726    +2     
+ Misses       7195     7193    -2     
Impacted Files Coverage Δ
datafusion/core/src/logical_plan/plan.rs 84.61% <ø> (-9.19%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 74.75% <94.82%> (+6.79%) ⬆️
datafusion/optimizer/src/utils.rs 32.25% <0.00%> (-0.54%) ⬇️
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
datafusion/expr/src/window_frame.rs 93.27% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9306534...0d748b6. Read the comment docs.

@andygrove andygrove changed the title MINOR: Move some tests from core to expr Move some tests from core to expr Jun 5, 2022
@yjshen yjshen merged commit bbb674a into apache:master Jun 6, 2022
@andygrove andygrove deleted the move-plan-display-tests branch January 27, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants