Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate datafusion::logical_plan module #2728

Closed
wants to merge 4 commits into from

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jun 14, 2022

Which issue does this PR close?

Part of #2683

Rationale for this change

The core logical_plan module consists purely of re-exports of other items and I would like to remove it in 11.0.0

What changes are included in this PR?

  • Deprecate the core logical_plan module
  • Rewrite imports to import items from real location

Are there any user-facing changes?

Yes, module is deprecated but this is not a breaking change

@github-actions github-actions bot added the core Core DataFusion crate label Jun 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2728 (a231cd0) into master (9ae1731) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #2728      +/-   ##
==========================================
- Coverage   84.86%   84.86%   -0.01%     
==========================================
  Files         270      270              
  Lines       47722    47722              
==========================================
- Hits        40501    40500       -1     
- Misses       7221     7222       +1     
Impacted Files Coverage Δ
benchmarks/src/bin/tpch.rs 39.52% <ø> (ø)
datafusion/core/src/dataframe.rs 86.23% <ø> (ø)
datafusion/core/src/datasource/datasource.rs 100.00% <ø> (ø)
datafusion/core/src/datasource/empty.rs 76.92% <ø> (ø)
datafusion/core/src/datasource/file_format/avro.rs 69.56% <ø> (ø)
datafusion/core/src/datasource/file_format/csv.rs 100.00% <ø> (ø)
datafusion/core/src/datasource/file_format/json.rs 98.87% <ø> (ø)
datafusion/core/src/datasource/file_format/mod.rs 90.90% <ø> (ø)
...afusion/core/src/datasource/file_format/parquet.rs 87.32% <ø> (ø)
datafusion/core/src/datasource/listing/table.rs 90.35% <ø> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae1731...a231cd0. Read the comment docs.

@andygrove andygrove marked this pull request as ready for review June 14, 2022 02:25
@andygrove andygrove marked this pull request as draft June 14, 2022 02:52
@andygrove andygrove closed this Jun 14, 2022
@andygrove andygrove deleted the remove-core-logical-plan branch January 27, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants