Improve cache in github actions #2945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 20, 2022
| - name: Cache Rust dependencies | ||
| uses: actions/cache@v3 | ||
| with: | ||
| # these represent compiled steps of both dependencies and arrow | ||
| # and thus are specific for a particular OS, arch and rust version. | ||
| path: /github/home/target | ||
| key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{ matrix.rust }}- | ||
| key: ${{ runner.os }}-${{ matrix.arch }}-${{ matrix.rust }}-target-${{ github.sha }} |
There was a problem hiding this comment.
This is the core change -- put the sha in to the cache
alamb
commented
Jul 20, 2022
| @@ -473,13 +473,7 @@ jobs: | |||
| with: | |||
| path: /github/home/.cargo | |||
| # this key equals the ones on `linux-build-lib` for re-use | |||
| key: cargo-cache- | |||
| - name: Cache Rust dependencies | |||
There was a problem hiding this comment.
As this job runs cargo fmt there is no reason to restore the contents of target as part of the job
|
🤔 it did not appear to help: https://github.com/apache/arrow-datafusion/runs/7432229787?check_suite_focus=true |
|
Took a different approach instead: #2948 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #2947
Rationale for this change
I have seen several PR checks failing recently related to "out of disk space", for example: https://github.com/apache/arrow-datafusion/runs/7430371132?check_suite_focus=true
You can see from that PR that the cargo cache doesn't seem to be very effective (it downloads many crates). It also seems to recompile all the dependencies, despite restoring a cache.
I believe the cache that is being used is not useful (just restoring a bunch of old files that have been outdated for a long time)
What changes are included in this PR?
targetto include the git sha (as the point is to restore files from thelinux-build-libjob earlier)Are there any user-facing changes?
No