Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate contributors guide #3128

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

kmitchener
Copy link
Contributor

Which issue does this PR close?

Closes #3127 .

Rationale for this change

What changes are included in this PR?

See the issue

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 13, 2022
@kmitchener
Copy link
Contributor Author

@andygrove wdyt?

Maybe Roadmap docs are actually part of the user guide? As a user of DataFusion, I'm interested in what the roadmap is, but it's less relevant for how to contribute to DF.

Anyway, looking for early feedback whether to abandon this approach or not

@codecov-commenter
Copy link

Codecov Report

Merging #3128 (272b69c) into master (b1765f7) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3128      +/-   ##
==========================================
- Coverage   85.95%   85.94%   -0.01%     
==========================================
  Files         291      291              
  Lines       52382    52382              
==========================================
- Hits        45025    45022       -3     
- Misses       7357     7360       +3     
Impacted Files Coverage Δ
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.60% <0.00%> (-0.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove
Copy link
Member

andygrove commented Aug 13, 2022

I was working on #3129 before I saw this. We should probably merge yours first.

@andygrove
Copy link
Member

Maybe Roadmap docs are actually part of the user guide? As a user of DataFusion, I'm interested in what the roadmap is, but it's less relevant for how to contribute to DF.

I like the approach in this PR. I see the roadmap as part of the developer resources. We can always link to it from the user guide as well though.

@kmitchener
Copy link
Contributor Author

I'm going to mark it ready for review then and we can continue with more changes on top once it's been merged in.

@kmitchener kmitchener marked this pull request as ready for review August 13, 2022 17:39
@andygrove andygrove merged commit 48f9b7a into apache:master Aug 13, 2022
@ursabot
Copy link

ursabot commented Aug 13, 2022

Benchmark runs are scheduled for baseline = b1765f7 and contender = 48f9b7a. 48f9b7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygrove andygrove mentioned this pull request Aug 15, 2022
17 tasks
@kmitchener kmitchener deleted the separate-contributors-guide branch August 18, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: proposal for consolidating docs into a Contributor Guide
4 participants