-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate contributors guide #3128
separate contributors guide #3128
Conversation
@andygrove wdyt? Maybe Roadmap docs are actually part of the user guide? As a user of DataFusion, I'm interested in what the roadmap is, but it's less relevant for how to contribute to DF. Anyway, looking for early feedback whether to abandon this approach or not |
Codecov Report
@@ Coverage Diff @@
## master #3128 +/- ##
==========================================
- Coverage 85.95% 85.94% -0.01%
==========================================
Files 291 291
Lines 52382 52382
==========================================
- Hits 45025 45022 -3
- Misses 7357 7360 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I was working on #3129 before I saw this. We should probably merge yours first. |
I like the approach in this PR. I see the roadmap as part of the developer resources. We can always link to it from the user guide as well though. |
I'm going to mark it ready for review then and we can continue with more changes on top once it's been merged in. |
Benchmark runs are scheduled for baseline = b1765f7 and contender = 48f9b7a. 48f9b7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3127 .
Rationale for this change
What changes are included in this PR?
See the issue
Are there any user-facing changes?