-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Fix broken links in contrib guide #3135
Conversation
@kmitchener fyi |
Codecov Report
@@ Coverage Diff @@
## master #3135 +/- ##
=======================================
Coverage 85.88% 85.88%
=======================================
Files 291 291
Lines 52770 52770
=======================================
Hits 45321 45321
Misses 7449 7449 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- [ci/scripts/rust_fmt.sh](../../../ci/scripts/rust_fmt.sh) | ||
- [ci/scripts/rust_clippy.sh](../../../ci/scripts/rust_clippy.sh) | ||
- [ci/scripts/rust_toml_fmt.sh](../../../ci/scripts/rust_toml_fmt.sh) | ||
- [ci/scripts/rust_fmt.sh](https://github.com/apache/arrow-datafusion/blob/master/ci/scripts/rust_fmt.sh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change does mean that they won't work locally on people's machines, but not sure how much of an issue that is... It would be nice if we could have both work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I could add a script to copy the files, search and replace the links, then build the HTML ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tustvold I changed approach here and added a script to fix up the links when publishing
2b5c9ee
to
1ae4463
Compare
@alamb I'd like to get this in before releasing 11.0.0 |
Benchmark runs are scheduled for baseline = e57dead and contender = ccd9406. ccd9406 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
N/A
Rationale for this change
Fix broken links in published docs.
Before
After
What changes are included in this PR?
This script only edits one file because there is only file with such relative links:
Are there any user-facing changes?