Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Union types coercion #3513

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

gandronchik
Copy link
Contributor

@gandronchik gandronchik commented Sep 16, 2022

Which issue does this PR close?

Union columns with different types

closes #3467

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Sep 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3513 (57962b9) into master (25c029c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3513      +/-   ##
==========================================
- Coverage   85.75%   85.74%   -0.01%     
==========================================
  Files         299      299              
  Lines       55311    55352      +41     
==========================================
+ Hits        47432    47462      +30     
- Misses       7879     7890      +11     
Impacted Files Coverage Δ
datafusion/core/src/physical_plan/union.rs 96.93% <100.00%> (+0.27%) ⬆️
datafusion/expr/src/expr_rewriter.rs 81.18% <100.00%> (+0.64%) ⬆️
datafusion/expr/src/logical_plan/builder.rs 90.37% <100.00%> (+0.20%) ⬆️
datafusion/sql/src/planner.rs 81.07% <100.00%> (+0.10%) ⬆️
datafusion/common/src/dfschema.rs 93.63% <0.00%> (-4.15%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.68% <0.00%> (-0.17%) ⬇️
datafusion/common/src/scalar.rs 85.18% <0.00%> (+0.06%) ⬆️
datafusion/core/src/physical_plan/metrics/value.rs 87.43% <0.00%> (+0.50%) ⬆️
datafusion/expr/src/expr_schema.rs 63.47% <0.00%> (+0.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gandronchik -- I think this PR is looking really good.

The only thing I think is needed prior to merge is 2 more tests. ❤️ Thank you!

datafusion/expr/src/expr_rewriter.rs Show resolved Hide resolved
datafusion/expr/src/logical_plan/builder.rs Outdated Show resolved Hide resolved
datafusion/sql/src/planner.rs Show resolved Hide resolved
@gandronchik
Copy link
Contributor Author

Thanks @gandronchik -- I think this PR is looking really good.

The only thing I think is needed prior to merge is 2 more tests. ❤️ Thank you!

Hi @alamb. Thank you for review. I added more tests and also fixed few bugs 🙏

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great -- thank you @gandronchik . I went over the tests carefully and 👍

@alamb alamb merged commit 4b1e044 into apache:master Sep 19, 2022
@ursabot
Copy link

ursabot commented Sep 19, 2022

Benchmark runs are scheduled for baseline = f30fc4e and contender = 4b1e044. 4b1e044 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

gandronchik added a commit to cube-js/arrow-datafusion that referenced this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Union columns with different types
4 participants