-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Union types coercion #3513
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3513 +/- ##
==========================================
- Coverage 85.75% 85.74% -0.01%
==========================================
Files 299 299
Lines 55311 55352 +41
==========================================
+ Hits 47432 47462 +30
- Misses 7879 7890 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gandronchik -- I think this PR is looking really good.
The only thing I think is needed prior to merge is 2 more tests. ❤️ Thank you!
57962b9
to
6e6b766
Compare
Hi @alamb. Thank you for review. I added more tests and also fixed few bugs 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great -- thank you @gandronchik . I went over the tests carefully and 👍
Benchmark runs are scheduled for baseline = f30fc4e and contender = 4b1e044. 4b1e044 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Union columns with different types
closes #3467