remove the type coercion in the simplify_expressions rule #3657
Conversation
| // If we don't do the type coercion, we will meet the | ||
| // https://github.com/apache/arrow-datafusion/issues/3556 when create the physical expr | ||
| // to try evaluate the result. | ||
| let expr = expr.rewrite(&mut self.type_coercion_helper)?; |
There was a problem hiding this comment.
remove the type coercion in the simplify expression, because of it was done before this rule
|
Benchmark runs are scheduled for baseline = 29b8bbd and contender = 0d1cd55. 0d1cd55 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
After this #3636 merged, we don't need to do the type coercion in the
simplify_expressions.Like the comments in #3556 (comment)
Closes #3556
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?