Drive sqllogictest runner on directory contents rather than hard coded list #4472
Conversation
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn show_all() { |
There was a problem hiding this comment.
moved to a data file rather than .rs file 🎉
There was a problem hiding this comment.
Yeah, step by step migration in progress
|
|
||
| fn test_filename(&self) -> &'static str { | ||
| match self { | ||
| TestCategory::Aggregate => "aggregate.slt", |
There was a problem hiding this comment.
Rather than hard coding this list, I propose instead listing the files in the directory instead
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn show_all() { |
There was a problem hiding this comment.
Yeah, step by step migration in progress
|
|
||
| fn test_filename(&self) -> &'static str { | ||
| match self { | ||
| TestCategory::Aggregate => "aggregate.slt", |
|
Benchmark runs are scheduled for baseline = 1aa645f and contender = b229e0f. b229e0f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #4471
Rationale for this change
Basically I want to be able to add new files easily without having to define a test setup if I don't want todo
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
no
cc @mvanschellebeeck and @xudong963