Support non-tuple expression for in-subquery to join #4725
Conversation
ygf11
changed the title
ygf11
changed the title
|
|
||
| #[tokio::test] | ||
| async fn reduce_where_in_to_expr_equijoin() -> Result<()> { | ||
| let ctx = create_join_context("t1_id", "t2_id", false)?; |
| let (on, filter) = | ||
| // When left is a constant expression, like 1, | ||
| // the join predicate will be `1 = right_key`, it is better to add it to filter. | ||
| if left_key.to_columns()?.is_empty() { | ||
| let equi_expr = | ||
| Expr::eq(*expr.clone(), Expr::Column(right_key)); | ||
| (vec![], Some(equi_expr)) | ||
| } else { |
There was a problem hiding this comment.
IMHO, I think it's a good improvement but maybe isn't suitable to put in this rule.🤔
It could be better to handle separate/handle on/joinfilter in a new rule(we also can add more improvement in it).
Just a thought, I think we also can add a TODO, and handle them as a future ticket.
There was a problem hiding this comment.
It could be better to handle separate/handle on/joinfilter in a new rule(we also can add more improvement in it).
Agree.
There is another pr #4711 which will separate equi and non-equi predicate from filter.
We can add the left-key = right-key to join-filter in this rule, and let the other rule do the separating works.
Got the wrong person 😆 |
|
why not implement this in the rule The two rule of |
Yes, I add it in new PR #4731 |
|
Close this pr, and I will submit a new pr based on |
Which issue does this PR close?
Closes #4724.
Rationale for this change
Currently datafusion support rewrite in-subquery to join when the expression is a column, like:
but following sql does not works:
We can rewrite these subquery to join also.
What changes are included in this PR?
In
SubqueryFilterToJoin:where x+1 in (...)to equi-join.where 1 in (..)to non equi-join.Are these changes tested?
Yes
Are there any user-facing changes?