Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify parquet filter predicate test, fix Page Filtering Incorrectly Handles Pages with Different Row Counts #4743

Merged
merged 9 commits into from
Dec 28, 2022
Merged

Simplify parquet filter predicate test, fix Page Filtering Incorrectly Handles Pages with Different Row Counts #4743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2aedc3a
Simplify filter predicate test
tustvold Dec 27, 2022
523466c
Fix pruning logic (#4744)
tustvold Dec 27, 2022
6654e44
Format
tustvold Dec 27, 2022
4b1058d
Fix oom_sort
tustvold Dec 28, 2022
9a4bd13
Merge remote-tracking branch 'upstream/master' into simplify-filter-p…
tustvold Dec 28, 2022
f5bdd3f
Fix tests
tustvold Dec 28, 2022
427672c
Format
tustvold Dec 28, 2022
c95ca24
Clippy
tustvold Dec 28, 2022
cc5336d
Clippy
tustvold Dec 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/core/src/physical_plan/file_format/parquet/page_filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ fn prune_pages_in_one_row_group(
let mut sum_row = *row_vec.first().unwrap();
let mut selected = *values.first().unwrap();
trace!("Pruned to to {:?} using {:?}", values, pruning_stats);
for (i, &f) in values.iter().skip(1).enumerate() {
for (i, &f) in values.iter().enumerate().skip(1) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the cause of #4744

if f == selected {
sum_row += *row_vec.get(i).unwrap();
} else {
Expand Down
Loading