fix: case expressions type coercion
#5796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5694.
Rationale for this change
While building projection schema (initial planning step),
CASEreturn type calculated as output type of firstWHEN ... THEN ...which could potentially cause erroneous type coercions at later planning stages.What changes are included in this PR?
Output type of
CASEexpressions, while building projection schema, now considers all THEN-types and ELSE-type (if exists) and uses commonget_coerce_type_for_case_whentype coercion routine.Are these changes tested?
Test cases for
CASEexpression with mixed NULL/NOT NULL THEN/ELSE-types addedAre there any user-facing changes?
No