Specialized Cursor for StringArray and BinaryArray #5964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Apr 11, 2023
| type Values = Self; | ||
|
|
||
| fn values(&self) -> Self::Values { | ||
| self.clone() |
There was a problem hiding this comment.
I originally planned to make it so that this deconstructed to the underlying buffers, in order to avoid redundant codegen for strings and binary arrays. Unfortunately this needed apache/arrow-rs#4048
In practice the additional codegen is not likely to matter, we can always revisit if it becomes a problem
There was a problem hiding this comment.
Can we at least leave a reference to apache/arrow-rs#4048 as a comment with a hint about how to reduce the codegen once apache/arrow-rs#4048 is releaed?
alamb
approved these changes
Apr 11, 2023
| type Values = Self; | ||
|
|
||
| fn values(&self) -> Self::Values { | ||
| self.clone() |
There was a problem hiding this comment.
Can we at least leave a reference to apache/arrow-rs#4048 as a comment with a hint about how to reduce the codegen once apache/arrow-rs#4048 is releaed?
korowa
pushed a commit
to korowa/arrow-datafusion
that referenced
this pull request
Apr 13, 2023
* Generify * Specialized cursor for StringArray and BinaryArray * fix clippy * Review feedback --------- Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5882
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?