Disable skip_failed_rules optimizer config by default
#6265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
changed the title
skip_failed_rules optimizer rules by default
alamb
changed the title
skip_failed_rules optimizer rules by defaultskip_failed_rules optimizer config by default
comphead
reviewed
May 8, 2023
| @@ -576,6 +576,8 @@ async fn support_order_by_correlated_columns() -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| // TODO: issue https://github.com/apache/arrow-datafusion/issues/6263 | |||
There was a problem hiding this comment.
👍 so only 1 test gets failed on optimization rules?
There was a problem hiding this comment.
Which rule fail this test ?
There was a problem hiding this comment.
Which rule fail this test ?
decorrelate_where_in, you can see issue #6263
There was a problem hiding this comment.
I will fix this rule later.
|
This is a I prepare to wait for more opinion for it. |
Given how many bugs and confusion this rule has caused I strongly support this behavior change -- the fact we have a workaround (to turn on the setting) is great. I think waiting for more opinions is a great idea, BTW |
liukun4515
approved these changes
May 10, 2023
|
Thanks everyone ❤️ |
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
May 11, 2023
* Disable skip_failed_rules default * fix slt
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4615.
Rationale for this change
#4685
What changes are included in this PR?
Disable skip_failed_rules default
Are these changes tested?
Are there any user-facing changes?
YES!!!
This PR change default behavior.