-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated sort.rs to show TopK
#7751
Conversation
solves: apache#7750 Replaced `SortExec: fetch={fetch}, expr=[{}]` with 'SortExec: TopK(fetch={fetch}), expr=[{}]' in [sort.rs](https://github.com/apache/arrow-datafusion/blob/main/datafusion/physical-plan/src/sorts/sort.rs) file
This looks really close @Night-Amber3301 -- thank you. I think some of the clippy errors will be resolved if you merge up from main. And it looks like there are just a few more tests to update Let me know if you would like to some help and thanks agian! |
Yeah sure, thanks for consideration, I would love to work on it, will go through it in a while. |
I've merged it up from main, please check it out. Thanks! |
It looks like somehow your changes were not pushed to github (the UI doesn't show any new changes) |
Any suggestions on why is this happening? |
Perhaps you haven't pushed the change to github? What command are you using? I would expect you would hav to do something like
And make sure your "upstream" was set to your fork |
Can you provide your git log to here? you can get the git log by
in your project workspace |
@liukun4515 Here are the logs: @Night-Amber3301 ➜ /workspaces/arrow-datafusion (patch-1) $ git log
|
@@ -769,7 +769,7 @@ impl DisplayAs for SortExec { | |||
write!( | |||
f, | |||
// TODO should this say topk? | |||
"SortExec: fetch={fetch}, expr=[{}]", | |||
"SortExec: TopK(fetch={fetch}), expr=[{}]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the sort does not use TopK, should we keep the format like "SortExec: fetch={fetch}, expr=[{}]"
🤔?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that is the intention
Marking as draft as this PR is not waiting on feedback. Please mark it as ready for review when it is next ready |
Closes: #7750
Replaced
SortExec: fetch={fetch}, expr=[{}]
withSortExec: TopK(fetch={fetch}), expr=[{}]
in sort.rs file