Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add count distinct group by date_bin #8178

Closed
wants to merge 1 commit into from

Conversation

NGA-TRAN
Copy link
Contributor

Which issue does this PR close?

Test for regression #8175

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Nov 14, 2023
Copy link
Contributor Author

@NGA-TRAN NGA-TRAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb : these are tests for #8175 but it seems you already added them in 3466168

Feel free to close this

select date_bin(interval '1 minute', ts) as bin, count(distinct currency_from) as count from exchange_rates group by bin;

query error
select date_part('year', ts) as year, count(distinct currency_from) as count from exchange_rates group by year;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 tests should pass after this PR #8176 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant