Minor: reduce code duplication in PruningPredicate test #8441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
force-pushed
the
alamb/cleanup_pruning_tests
branch
from
cd9a6ef to
1a352dd
Compare
alamb
commented
Dec 23, 2023
| vec![Some(0), Some(4), None, Some(3)], // min | ||
| vec![Some(5), Some(6), Some(4), None], // max | ||
|
|
||
| prune_with_expr( |
There was a problem hiding this comment.
The idea is to reduce the boiler plate required to setup the test / prune the expression, and simply list the data and expected results. It may not be many less lines, but the logic is significantly less dense in my opinion
|
cc @yahoNanJing @crepererum do you have time to review this PR? |
|
@Ted-Jiang I wonder if you have some time to review this PR? |
viirya
approved these changes
Jan 3, 2024
|
Thank you @viirya and @Ted-Jiang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #8440
Rationale for this change
I made a function that was more concise and easier to understand than current tests which have substantial duplication, as part of #8440, but wanted to keep that PR as small as possible to make review easier.
What changes are included in this PR?
prune_with_exprto reduce code duplicationAre these changes tested?
all tests
Are there any user-facing changes?