-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: support bitmap for u8/16 and i8/16 in approx_distinct
#8462
Conversation
approx_distinct
} | ||
|
||
fn size(&self) -> usize { | ||
self.bitmap.serialized_size() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure is a proper way to measure roaring bitmap
Thank you @Weijun-H! This PR, though, looks like the implementation of |
I wonder what we should do with this PR now we have |
While I'm still not sure if this PR fits |
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Which issue does this PR close?
Follow #1841
Closes #1109
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?