Bugfix: Add functional dependency check and aggregate try_new schema #8584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
ozankabak
changed the title
ozankabak
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
LGTM, thank you @mustafasrepo. This is a small bugfix PR resolving issues around the functional dependency mechanism and modification of aggregate executors during planning, but let's keep it open for a day or two in case anyone wants to quickly check it out.
alamb
approved these changes
Dec 19, 2023
| @@ -2162,4 +2194,56 @@ mod tests { | |||
| assert_eq!(res, common_requirement); | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_agg_exec_same_schema() -> Result<()> { | |||
There was a problem hiding this comment.
is there any way that this can be tested from SQL? Or does it require a programatic test?
There was a problem hiding this comment.
Actually I tried to produce this error from a SQL test. However couldn't reproduce it. The reason may be related to the some rules in physical optimizer has schema_check flag false. But I am not sure, I couldn't come up with a reproducer from the SQL query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Make sure schema doesn't change for Aggregate during recreation. Fix functional dependency for wildcard expressions
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?