Improve datafusion-cli print format tests
#8896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/rework_format_tests
branch
from
d7802a3 to
d1b0218
Compare
alamb
commented
Jan 17, 2024
| PrintFormat::Automatic, | ||
| ] { | ||
| // no output for empty batches, even with header set | ||
| PrintBatchesTest::new() |
There was a problem hiding this comment.
I think this style of test is clearer what is expected and what is covered
alamb
commented
Jan 17, 2024
| PrintBatchesTest::new() | ||
| .with_format(PrintFormat::Table) | ||
| .with_batches(split_batch(three_column_batch())) | ||
| .with_header(WithHeader::Ignored) |
There was a problem hiding this comment.
Now there is additional coverage for formats that ignore the with_header flag
alamb
force-pushed
the
alamb/rework_format_tests
branch
from
d1b0218 to
d028441
Compare
comphead
approved these changes
Jan 18, 2024
Dandandan
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as it build on #8895
Which issue does this PR close?
Related to #8702
Follow on to #8895
Rationale for this change
While working on #8895 I found the tests somewhat hard to follow and it was hard for me to understand if there were existing tests that covered I was changing.
It was also hard top understand the coverage in general given how the tests were structured
What changes are included in this PR?
Are these changes tested?
This PR is all tests (no code changes)
Are there any user-facing changes?
No