Replace usages of internal_err with exec_err where appropriate #9241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omega359
changed the title
Omega359
changed the title
comphead
reviewed
Feb 19, 2024
…e/internal_err_9164
Weijun-H
reviewed
Feb 20, 2024
Merged
…nsupported type errors." This reverts commit fe0517a.
9 tasks
alamb
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Thank you @Omega359 -- this looks great and I think we should get this asap as it will conflict with many of the function extraction PRs.
I took the liberty of merging up from main and resolving one such conflict and plan to merge this when the CI checks have passed
| @@ -58,7 +58,7 @@ impl NullIfFunc { | |||
| Self { | |||
| signature: | |||
| Signature::uniform(2, SUPPORTED_NULLIF_TYPES.to_vec(), | |||
| Volatility::Immutable, | |||
| Volatility::Immutable, | |||
There was a problem hiding this comment.
This is a strange change -- I wonder if cargo fmt doesn't see this file for some reason 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9164
Rationale for this change
Code cleanup.
What changes are included in this PR?
Only internal_err! for incorrect arg count or data type was migrated to exec_err, all other cases were left alone.
Are these changes tested?
Yes,
Are there any user-facing changes?
No.