Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows in main. #624

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Fix workflows in main. #624

merged 1 commit into from
Jan 2, 2025

Conversation

leerho
Copy link
Contributor

@leerho leerho commented Dec 28, 2024

Since the ds-java 6.1.1 release I mistakenly changed the name of some of the workflows not realizing the impact it had on certain triggers such as "workflow_dispatch", which, in order to work, has to exist in the default branch in the file with the same name.

This update fixes this issue along with an improved specification of the automatic "push" and "pull_request" triggers.

Indentation is being made consistent at the recommended 2 spaces per indent.

These same changes will have to be made in the 7.0.X branch in a subsequent PR.

Similar changes should also be made in the 6.1.X branch (but using a different Java version) in a subsequent PR. This is in case we ever need to run these workflows for the current ds-java 6.1.1 release.

Note: Due to the limited capabilities of GH actions, I will not be able to test these until they are merged into main.

@leerho leerho merged commit 7dfbf54 into main Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants