Create internal2 #129
Merged
Create internal2 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created MapHandleImpl
Successfully created interface proxies in memory package for the Map-Handle hierarchy. The real work is done in *Impl classes in the internal package.
Buffer hierarchy is not done. Many Errors in Test. Main compiles clean, no warnings.
Buffer hierarchy is not done, many errors in test. Main compiles clean, no warnings.
Next to refactor the tests. Lots of errors, which is expected.
Move all main classes to internal package. Create interface proxies for the memory package. This creates possibility to restrict access to internal package using JPMS in JDK 9+. All tests pass and the vast majority of tests are black-box tests.
src/main/java/org/apache/datasketches/memory/internal/BaseBufferImpl.java
Show resolved
Hide resolved
davecromberge
approved these changes
May 21, 2021
|
@leerho it looks like all the issues I raised have been addressed - PR looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactoring of the Memory package.
All memory classes have been moved to internal package. Created interface proxies for
the user API in the memory package. This creates possibility to restrict access to
internal package using JPMS in JDK 9+.
All tests pass and the vast majority of tests are black-box tests.