Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict ScimJacksonXmlBindJsonProvider to only handling SCIMple classes #404

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

bdemers
Copy link
Member

@bdemers bdemers commented Nov 3, 2023

Previously application/json requests may have lost any custom extension data.

This change adds applicaiton/json to the list of supproted media types (as recommended by the SCIM specs), but restricts it's types to ONLY classes known by SCIMple, and allows other MessageBodyReader/Writer to handle other requests

Fixes: #390

Previously application/json requests may have lost any custom extension data.

This change adds applicaiton/json to the list of supproted media types (as recommended by the SCIM specs), but restricts it's types to ONLY classes known by SCIMple, and allows other MessageBodyReader/Writer to handle other requests

Fixes: #390
@bdemers
Copy link
Member Author

bdemers commented Nov 3, 2023

@symphony-enrico Can you take a look at this?
I ran a quick test by defining another JacksonXmlBindJsonProvider (bound to */*) with an endpoint that returned a non-SCIMple class (just a hashmap), and that seemed to work well.
(no need to deal with complexities of multiple JAX-RS apps as I previously mentioned 🤞)

@bdemers bdemers merged commit 869be38 into develop Nov 21, 2023
2 checks passed
@bdemers bdemers deleted the restrict-reader-writer branch November 21, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant