Add docker dev environment #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
previously requested changes
Nov 12, 2018
Docker_build.md
Outdated
| @@ -0,0 +1,31 @@ | |||
| ## Doris Develop Environment based on docker | |||
There was a problem hiding this comment.
you should add ASF license header, like this
Docker_build.md
Outdated
|
|
||
| docker build -t palo:v1.0 . | ||
|
|
||
| -- palo is docker image repository name and base is tag name , you can change them to what you like |
There was a problem hiding this comment.
you should better change palo to doris
EmmyMiao87
reviewed
Nov 12, 2018
Dockerfile
Outdated
|
|
||
| # add code repository | ||
| ADD thirdparty /var/local/thirdparty | ||
|
|
There was a problem hiding this comment.
You should add palo source code in docker image too, otherwise you won't build palo.
morningman
requested changes
Nov 13, 2018
Dockerfile
Outdated
| # build third party | ||
| RUN /bin/bash thirdparty/build-thirdparty.sh \ | ||
| && ln -s ${DEFAULT_DIR}/thirdparty/installed/bin/thrift /usr/bin/thrift \ | ||
| && ln -s ${DEFAULT_DIR}/thirdparty/installed/ant/bin/ant /usr/bin/ant \ |
There was a problem hiding this comment.
We are not using ant any more, using maven instead.
There was a problem hiding this comment.
I have create docker directory and delete ant and change as other suggest
uestctxq
force-pushed
the
feature-docker-image
branch
from
d88d125 to
ada47af
Compare
morningman
dismissed
imay’s stale review
Commit log can be changed when merge, no need to create a new patach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.