Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add Rollup bug #337

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Fix add Rollup bug #337

merged 1 commit into from
Nov 22, 2018

Conversation

kangkaisen
Copy link
Contributor

Fix 332

1 when add_column_statistics, we should use use _table->num_key_fields(), not column_statistic_fields.size(), as rollup table num_key_fields will less than base table column_statistic_fields.size()

2 when adding rollup table, the base table column_statistic_fields maybe empty.

@chaoyli
Copy link
Contributor

chaoyli commented Nov 21, 2018

I have review your code and core dump info carefully. It may be a little difficulty.

  1. Adding rollup should not call LinkedSchemaChange Class. Because LinkedSchemaChange will not writer new data but create a hard link instead. It is not the semantics for adding rollup.
  2. CHECK in add_column_statistics is valid aside from LinkedSchemaChange. A new method should to be figured out to address this problem.
    I will reproduce this bug in my machine, and help to address this.

@kangkaisen
Copy link
Contributor Author

Add a special add_column_statistics method for linked_schema_change.

@chaoyli Hi, chaoyli. Please review. Thanks.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit cec1b97 into apache:master Nov 22, 2018
platoneko added a commit to platoneko/doris that referenced this pull request Jul 10, 2022
…rage_policy (apache#337)

 fix be ut after rename cooldown_resource to storage_policy
platoneko added a commit to platoneko/doris that referenced this pull request Jul 27, 2022
…rage_policy (apache#337)

 fix be ut after rename cooldown_resource to storage_policy
platoneko added a commit to platoneko/doris that referenced this pull request Jul 27, 2022
…rage_policy (apache#337)

 fix be ut after rename cooldown_resource to storage_policy
platoneko added a commit to platoneko/doris that referenced this pull request Jul 27, 2022
…rage_policy (apache#337)

 fix be ut after rename cooldown_resource to storage_policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants