-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix add Rollup bug #337
Merged
Merged
Fix add Rollup bug #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have review your code and core dump info carefully. It may be a little difficulty.
|
Add a special add_column_statistics method for linked_schema_change. @chaoyli Hi, chaoyli. Please review. Thanks. |
chaoyli
approved these changes
Nov 22, 2018
morningman
approved these changes
Nov 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
platoneko
added a commit
to platoneko/doris
that referenced
this pull request
Jul 10, 2022
…rage_policy (apache#337) fix be ut after rename cooldown_resource to storage_policy
platoneko
added a commit
to platoneko/doris
that referenced
this pull request
Jul 27, 2022
…rage_policy (apache#337) fix be ut after rename cooldown_resource to storage_policy
platoneko
added a commit
to platoneko/doris
that referenced
this pull request
Jul 27, 2022
…rage_policy (apache#337) fix be ut after rename cooldown_resource to storage_policy
platoneko
added a commit
to platoneko/doris
that referenced
this pull request
Jul 27, 2022
…rage_policy (apache#337) fix be ut after rename cooldown_resource to storage_policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 332
1 when add_column_statistics, we should use use _table->num_key_fields(), not column_statistic_fields.size(), as rollup table num_key_fields will less than base table column_statistic_fields.size()
2 when adding rollup table, the base table column_statistic_fields maybe empty.